Issue 9016050: Flag methods as not being valid compile time constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9016050: Flag methods as not being valid compile time constants (Closed)

Created:
8 years, 11 months ago by zundel

Modified:
8 years, 11 months ago

Reviewers:
gbracha, codefu

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Flag methods as not being valid compile time constants BUG=1000 TEST= Committed: https://code.google.com/p/dart/source/detail?r=2956

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -1 line)			Patch
M	compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java	View	2 chunks	+13 lines, -1 line	0 comments	Download
A	tests/language/src/ConstInit7NegativeTest.dart	View	1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

zundel

Gilad, Could you confirm that ConstInit7NegativeTest is a valid test? If I submit this as ...

8 years, 11 months ago (2012-01-03 18:17:53 UTC) #1

LGTM