Remove fragile check in DidProcessCrash...

Remove fragile check in DidProcessCrash
- the numbers were out of sync with result_codes.h
- can't use result_codes.h in base project so I extracted
the generic part of it.

Rahul: I hope I don't break installer assumptions here.
Dan: don't feel obligated to review.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4519

[Peter Kasting, 2008-11-02 01:00:14]

http://codereview.chromium.org/9012/diff/1/2
File base/process_util.h (right):

http://codereview.chromium.org/9012/diff/1/2#newcode50
Line 50: // Do not change the enumeration values or you could will break
third-party
Nit: "could will"?

http://codereview.chromium.org/9012/diff/1/3
File base/process_util_win.cc (right):

http://codereview.chromium.org/9012/diff/1/3#newcode192
Line 192: exitcode == PROCESS_END_PROCESS_WAS_HUNG ||
Is there come other CL where you're changing the exitcodes to match your new
values?  (Specifically, you changed "14" and "16" to "2")

http://codereview.chromium.org/9012/diff/1/4
File chrome/app/result_codes.h (right):

http://codereview.chromium.org/9012/diff/1/4#newcode23
Line 23: NORMAL_EXIT =           process_util::PROCESS_END_NORMAL_TERMINATON,
Nit: This spacing choice is weird.  Why not just the normal one space, or else
line all three up with the longest one?

[kuchhal, 2008-11-03 17:45:50]

Installer uses this enum in uninstall.cc but we are not using int values
directly. As long as you checked no one else is using exitcodes directly, looks
good to me.

[cpu_(ooo_6.6-7.5), 2008-11-03 21:57:57]

Changes made, Peter please look again.

http://codereview.chromium.org/9012/diff/1/3
File base/process_util_win.cc (right):

http://codereview.chromium.org/9012/diff/1/3#newcode192
Line 192: exitcode == PROCESS_END_PROCESS_WAS_HUNG ||
On 2008/11/02 01:00:14, pkasting wrote:
> Is there come other CL where you're changing the exitcodes to match your new
> values?  (Specifically, you changed "14" and "16" to "2")

No, there are no more CLs, only the stuff that rahulk has on the installer. I'll
check with omaha but I think they only care for zero and non-zero. 

I put the 14 there before and I think it is safe to eliminate here. The
important values to keep is 0 and 1.

http://codereview.chromium.org/9012/diff/1/4
File chrome/app/result_codes.h (right):

http://codereview.chromium.org/9012/diff/1/4#newcode23
Line 23: NORMAL_EXIT =           process_util::PROCESS_END_NORMAL_TERMINATON,
On 2008/11/02 01:00:14, pkasting wrote:
> Nit: This spacing choice is weird.  Why not just the normal one space, or else
> line all three up with the longest one?

Yeah, I was not happy either. I'll do single space.

[Peter Kasting, 2008-11-03 22:24:38]

LGTM