Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/process_util_win.cc

Issue 9012: Remove fragile check in DidProcessCrash... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/process_util.h ('k') | chrome/app/result_codes.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util_win.cc
===================================================================
--- base/process_util_win.cc (revision 4323)
+++ base/process_util_win.cc (working copy)
@@ -187,10 +187,9 @@
// Warning, this is not generic code; it heavily depends on the way
// the rest of the code kills a process.
- if (exitcode == 0 || // Normal termination.
- exitcode == 1 || // Killed by task manager.
- exitcode == 14 || // Killed because of a bad message.
- exitcode == 16 || // Killed by hung detector (see ResultCodes)
+ if (exitcode == PROCESS_END_NORMAL_TERMINATON ||
+ exitcode == PROCESS_END_KILLED_BY_USER ||
+ exitcode == PROCESS_END_PROCESS_WAS_HUNG ||
exitcode == 0xC0000354 || // STATUS_DEBUGGER_INACTIVE.
exitcode == 0xC000013A || // Control-C/end session.
exitcode == 0x40010004) { // Debugger terminated process/end session.
« no previous file with comments | « base/process_util.h ('k') | chrome/app/result_codes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698