Issue 9007008: Split Dr.Memory GYP defines into a separate constant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9007008: Split Dr.Memory GYP defines into a separate constant (Closed)

Created:
9 years ago by Timur Iskhodzhanov

Modified:
9 years ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, cmp, nsylvain+cc_chromium.org, Derek Bruening, Reid Kleckner

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build/

Visibility:
Public.

More Reviews

Description

Split Dr.Memory GYP defines into a separate constant BUG=108155 TBR=nsylvain Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115123

Patch Set 1 #

Total comments: 1

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	masters/master.chromium.fyi/master.cfg	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	scripts/master/factory/chromium_factory.py	View		2 chunks	+14 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

TBR http://codereview.chromium.org/9007008/diff/1/scripts/master/factory/chromium_factory.py File scripts/master/factory/chromium_factory.py (right): http://codereview.chromium.org/9007008/diff/1/scripts/master/factory/chromium_factory.py#newcode59 scripts/master/factory/chromium_factory.py:59: 'win_debug_disable_iterator_debugging=1 ' Derek, Reid: I'm leaving these two ...

9 years ago (2011-12-20 13:56:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/9007008/1

9 years ago (2011-12-20 13:57:02 UTC) #2

lgtm

Expand Messages | Collapse Messages