Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: scripts/master/factory/chromium_factory.py

Issue 9007008: Split Dr.Memory GYP defines into a separate constant (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « masters/master.chromium.fyi/master.cfg ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/factory/chromium_factory.py
===================================================================
--- scripts/master/factory/chromium_factory.py (revision 115121)
+++ scripts/master/factory/chromium_factory.py (working copy)
@@ -43,7 +43,6 @@
'win_debug_disable_iterator_debugging=1 '
'win_debug_Optimization=1 '
'win_debug_InlineFunctionExpansion=0 '
- 'win_debug_OmitFramePointers=0 '
'win_release_InlineFunctionExpansion=0 '
'win_release_OmitFramePointers=0 '
@@ -52,6 +51,20 @@
'werror= '
)
+ # TODO(timurrrr): investigate http://crbug.com/108155,
+ # uncomment and merge it with MEMORY_TOOLS_GYP_DEFINES.
+ # The commented parts of this list are wannabes but don't work yet.
+ DR_MEMORY_GYP_DEFINES = (
+ 'win_debug_RuntimeChecks=0 '
+ 'win_debug_disable_iterator_debugging=1 '
Timur Iskhodzhanov 2011/12/20 13:56:54 Derek, Reid: I'm leaving these two options here as
+ # 'win_debug_Optimization=1 '
+ # 'win_debug_InlineFunctionExpansion=0 '
+ # 'win_debug_OmitFramePointers=0 '
+
+ 'win_release_InlineFunctionExpansion=0 '
+ 'win_release_OmitFramePointers=0 '
+ )
+
# gclient custom vars
CUSTOM_VARS_GOOGLECODE_URL = ('googlecode_url', config.Master.googlecode_url)
CUSTOM_VARS_SOURCEFORGE_URL = ('sourceforge_url',
« no previous file with comments | « masters/master.chromium.fyi/master.cfg ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698