Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issue 9006038: [Coverity] Change some pass by values to pass by const refs. (Closed)

Created:
9 years ago by Dan Beam
Modified:
9 years ago
Reviewers:
dhollowa
CC:
chromium-reviews, dhollowa+watch_chromium.org
Visibility:
Public.

Description

[Coverity] Change some pass by values to pass by const refs. CID=8501 CID=100223 R=dhollowa@chromium.org

Patch Set 1 #

Patch Set 2 : removing const ref from enums #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/webdata/autofill_change.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/webdata/autofill_change.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dan Beam
9 years ago (2011-12-20 23:11:55 UTC) #1
dhollowa
LGTM. Thanks for the cleanup!
9 years ago (2011-12-20 23:14:08 UTC) #2
Dan Beam
On 2011/12/20 23:14:08, dhollowa wrote: > LGTM. Thanks for the cleanup! No prob, getting points ...
9 years ago (2011-12-20 23:14:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/9006038/1
9 years ago (2011-12-20 23:15:27 UTC) #4
Dan Beam
9 years ago (2011-12-20 23:30:48 UTC) #5
dhollowa
Thanks. Yup. LGTM.
9 years ago (2011-12-20 23:32:44 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-20 23:41:06 UTC) #7

Powered by Google App Engine
This is Rietveld 408576698