Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3876)

Unified Diff: chrome/browser/webdata/autofill_change.cc

Issue 9006038: [Coverity] Change some pass by values to pass by const refs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: removing const ref from enums Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/webdata/autofill_change.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/webdata/autofill_change.cc
diff --git a/chrome/browser/webdata/autofill_change.cc b/chrome/browser/webdata/autofill_change.cc
index 454d7b966e48e49bc39f0878bc2e8993131b375f..e6bb08534856aa7d4725b201310bfd501ebfa4ce 100644
--- a/chrome/browser/webdata/autofill_change.cc
+++ b/chrome/browser/webdata/autofill_change.cc
@@ -15,7 +15,7 @@ AutofillChange::~AutofillChange() {
}
AutofillProfileChange::AutofillProfileChange(
- Type type, std::string key, const AutofillProfile* profile)
+ Type type, const std::string& key, const AutofillProfile* profile)
: GenericAutofillChange<std::string>(type, key),
profile_(profile) {
DCHECK(type == ADD ? (profile && profile->guid() == key) : true);
@@ -34,7 +34,7 @@ bool AutofillProfileChange::operator==(
}
AutofillCreditCardChange::AutofillCreditCardChange(
- Type type, std::string key, const CreditCard* credit_card)
+ Type type, const std::string& key, const CreditCard* credit_card)
: GenericAutofillChange<std::string>(type, key), credit_card_(credit_card) {
DCHECK(type == ADD ? (credit_card && credit_card->guid() == key) : true);
DCHECK(type == UPDATE ? (credit_card && credit_card->guid() == key) : true);
« no previous file with comments | « chrome/browser/webdata/autofill_change.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698