[sql] WARN_UNUSED_RESULT on Execute().

[sql] WARN_UNUSED_RESULT on Execute().

Goal is to encourage callers to handle errors, especially in cases
like schema changes, where dropped errors can result in broken
databases.

Many CREATE INDEX calls where ignoring errors rather than checking if
the index already existed before creating it.  Recoded those to CREATE
INDEX IF NOT EXISTS, which is for exactly this purpose.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115725

[Scott Hess - ex-Googler, 2011-12-21 00:56:54]

wtc for chrome/browser/net/OWNERS .

[wtc, 2011-12-21 01:16:16]

LGTM.

http://codereview.chromium.org/9005036/diff/1/chrome/browser/net/sqlite_persi...
File chrome/browser/net/sqlite_persistent_cookie_store.cc (left):

http://codereview.chromium.org/9005036/diff/1/chrome/browser/net/sqlite_persi...
chrome/browser/net/sqlite_persistent_cookie_store.cc:297: // so we want those
people to get it. Ignore errors, since it may exist.

shess: please confirm that you want this function to fail if
the index already exists.

Or do these db->Execute() calls succeed (but do nothing) if
the index already exists?

[Scott Hess - ex-Googler, 2011-12-21 02:41:01]

http://codereview.chromium.org/9005036/diff/1/chrome/browser/net/sqlite_persi...
File chrome/browser/net/sqlite_persistent_cookie_store.cc (left):

http://codereview.chromium.org/9005036/diff/1/chrome/browser/net/sqlite_persi...
chrome/browser/net/sqlite_persistent_cookie_store.cc:297: // so we want those
people to get it. Ignore errors, since it may exist.
On 2011/12/21 01:16:17, wtc wrote:
> 
> shess: please confirm that you want this function to fail if
> the index already exists.
> 
> Or do these db->Execute() calls succeed (but do nothing) if
> the index already exists?

Yeah, the "CREATE INDEX IF NOT EXISTS" will succeed if the index already exists,
even if it resulted from a different create entirely, but will fail if there is
some other error while creating the index.  Such errors could include a
read-only database, table corruption, running out of disk space, etc.

I'll instrument the code and make sure this is actually happening.  I've run
stuff, everything seems to work, but that could be a false negative...

[Scott Hess - ex-Googler, 2011-12-22 02:42:27]

Greg, any input?  Since this was part of your yak herd...

[Greg Billock, 2011-12-22 15:16:40]

On 2011/12/22 02:42:27, shess wrote:
> Greg, any input?  Since this was part of your yak herd...

lgtm

[Scott Hess - ex-Googler, 2011-12-22 20:29:53]

Since linux_rel did not fail the PanelDownloadTest.* tests the other two failed,
and I have been unable to repro those failures locally, so I'm going to press
the pretty button.

[commit-bot: I haz the power, 2011-12-22 20:30:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/9005036/6001

[commit-bot: I haz the power, 2011-12-22 20:30:15]

Presubmit check for 9005036-6001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: webkit/quota/quota_database_unittest.cc

Presubmit checks took 1.6s to calculate.

[Scott Hess - ex-Googler, 2011-12-22 20:58:49]

On 2011/12/22 20:30:15, I haz the power (commit-bot) wrote:
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for: webkit/quota/quota_database_unittest.cc

OOOPS.  Michael?

[Scott Hess - ex-Googler, 2011-12-22 23:13:49]

On 2011/12/22 20:58:49, shess wrote:
> On 2011/12/22 20:30:15, I haz the power (commit-bot) wrote:
> > ** Presubmit ERRORS **
> > Missing LGTM from an OWNER for: webkit/quota/quota_database_unittest.cc
> 
> OOOPS.  Michael?

His desk looks very empty, today, expanding my net.

[michaeln, 2011-12-23 14:26:29]

LGTM

[Scott Hess - ex-Googler, 2011-12-23 15:51:41]

On 2011/12/23 14:26:29, michaeln wrote:
> LGTM

Thanks!

[commit-bot: I haz the power, 2011-12-23 15:51:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shess@chromium.org/9005036/6001

[commit-bot: I haz the power, 2011-12-23 17:07:22]

Change committed as 115725