chrome/browser/history/shortcuts_database.cc - Issue 9005036: [sql] WARN_UNUSED_RESULT on Execute().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/shortcuts_database.cc

Issue 9005036: [sql] WARN_UNUSED_RESULT on Execute(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix compile error in quota_database_unittest.cc. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/shortcuts_database.cc

diff --git a/chrome/browser/history/shortcuts_database.cc b/chrome/browser/history/shortcuts_database.cc

index 45e11a95c148bf0660f613f384e7026413e2d7a0..5b761df0e0f3c39e360ef68cb1b1b1193fd492fa 100644

--- a/chrome/browser/history/shortcuts_database.cc

+++ b/chrome/browser/history/shortcuts_database.cc

@@ -168,17 +168,10 @@ bool ShortcutsDatabase::DeleteShortcutsWithUrl(

}

bool ShortcutsDatabase::DeleteAllShortcuts() {

- sql::Statement s(db_.GetCachedStatement(SQL_FROM_HERE,

- "DROP TABLE " kShortcutsDBName));

- if (!s) {

- NOTREACHED() << "Statement prepare failed";

+ if (!db_.Execute("DELETE FROM " kShortcutsDBName))

return false;

- }

- if (!s.Run())

- return false;

- EnsureTable();

- db_.Execute("VACUUM");

+ ignore_result(db_.Execute("VACUUM"));

return true;

}