Issue 9005015: Coverity: Initialize member variables.

Issue 9005015: Coverity: Initialize member variables. (Closed)

Created:
9 years ago by James Hawkins

Modified:
9 years ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews, vrk (LEFT CHROMIUM), jam, amit, mihaip+watch_chromium.org, cbentzel+watch_chromium.org, acolwell+watch_chromium.org, joi+watch-content_chromium.org, wez+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, annacc+watch_chromium.org, ihf+watch_chromium.org, jstritar+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, sanjeevr, dpranke-watch+content_chromium.org, simonmorris+watch_chromium.org, sergeyu+watch_chromium.org, scherkus (not reviewing), jamiewalch+watch_chromium.org, hclam+watch_chromium.org, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Coverity: Initialize member variables. CID=6462,16392,16996,17268,100987,101018,102401,102417,102476,102484,102513 102546,102552,102567,102617,102674,102677,102678,102679,102681,102685, 102714,102750,102751,102781 BUG=none TEST=none R=groby Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115234

Patch Set 1 #

Total comments: 3

Patch Set 2 : Build fix. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -20 lines)			Patch
M	chrome/browser/extensions/extension_web_socket_proxy_private_api.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/history/in_memory_url_index.cc	View		1 chunk	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_subsystem.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/speech/speech_input_bubble_views.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/snapshot_tab_helper.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/sad_tab_view.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/web_intent_picker_view.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_message_filter.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	crypto/p224_spake.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	crypto/signature_creator_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/pipeline_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	media/filters/reference_audio_renderer.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	net/base/origin_bound_cert_store.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	net/socket/ssl_client_socket.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/ssl_client_socket.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/socket/ssl_client_socket_nss.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/socket/ssl_server_socket_nss.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/socket/transport_client_socket_pool.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	net/url_request/url_request_job_manager.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/proxy/serialized_structs.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/shared_impl/ppb_file_io_shared.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	remoting/jingle_glue/ssl_socket_adapter.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/glue/context_menu.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/media/webmediaplayer_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_transport_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_websocket_impl.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

LGTM modulo nits/questions http://codereview.chromium.org/9005015/diff/1/net/base/origin_bound_cert_store.cc File net/base/origin_bound_cert_store.cc (right): http://codereview.chromium.org/9005015/diff/1/net/base/origin_bound_cert_store.cc#newcode10 net/base/origin_bound_cert_store.cc:10: : type_(CLIENT_CERT_INVALID_TYPE) { You might want ...

9 years ago (2011-12-20 20:03:34 UTC) #2

James Hawkins

http://codereview.chromium.org/9005015/diff/1/net/url_request/url_request_job_manager.cc File net/url_request/url_request_job_manager.cc (right): http://codereview.chromium.org/9005015/diff/1/net/url_request/url_request_job_manager.cc#newcode266 net/url_request/url_request_job_manager.cc:266: : allowed_thread_(0), On 2011/12/20 20:03:34, groby wrote: > Are ...

9 years ago (2011-12-20 20:41:36 UTC) #3

SLGTM

Expand Messages | Collapse Messages