Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: net/url_request/url_request_job_manager.cc

Issue 9005015: Coverity: Initialize member variables. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_job_manager.h" 5 #include "net/url_request/url_request_job_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/memory/singleton.h" 9 #include "base/memory/singleton.h"
10 #include "build/build_config.h" 10 #include "build/build_config.h"
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 DCHECK(IsAllowedThread()); 255 DCHECK(IsAllowedThread());
256 256
257 base::AutoLock locked(lock_); 257 base::AutoLock locked(lock_);
258 258
259 InterceptorList::iterator i = 259 InterceptorList::iterator i =
260 std::find(interceptors_.begin(), interceptors_.end(), interceptor); 260 std::find(interceptors_.begin(), interceptors_.end(), interceptor);
261 DCHECK(i != interceptors_.end()); 261 DCHECK(i != interceptors_.end());
262 interceptors_.erase(i); 262 interceptors_.erase(i);
263 } 263 }
264 264
265 URLRequestJobManager::URLRequestJobManager() : enable_file_access_(false) { 265 URLRequestJobManager::URLRequestJobManager()
266 #ifndef NDEBUG 266 : allowed_thread_(0),
groby-ooo-7-16 2011/12/20 20:03:34 Are those intentionally uninitialized in debug bui
James Hawkins 2011/12/20 20:41:37 No, it's a bug.
267 allowed_thread_ = 0; 267 allowed_thread_initialized_(false),
268 allowed_thread_initialized_ = false; 268 enable_file_access_(false) {
269 #endif
270 } 269 }
271 270
272 URLRequestJobManager::~URLRequestJobManager() {} 271 URLRequestJobManager::~URLRequestJobManager() {}
273 272
274 } // namespace net 273 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698