Issue 9004046: Popup windows' state should always be SHOW_STATE_NORMAL, not depend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9004046: Popup windows' state should always be SHOW_STATE_NORMAL, not depend (Closed)

Created:
8 years, 12 months ago by Cem Kocagil

Modified:
8 years, 11 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, stevenjb

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Popup windows' state should always be SHOW_STATE_NORMAL, not depend on the saved window state. BUG=106967 TEST=Windows opened by window.open should be unmaximized by default Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116389

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	AUTHORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/ui/views/frame/browser_view.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

Ben Goodger (Google)

The patch looks good... can you also add your details to src/AUTHORS and update this ...

8 years, 11 months ago (2012-01-04 19:26:05 UTC) #3

Cem Kocagil

On 2012/01/04 19:26:05, Ben Goodger (Google) wrote: > The patch looks good... can you also ...

8 years, 11 months ago (2012-01-04 20:03:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cem.kocagil@gmail.com/9004046/5001

8 years, 11 months ago (2012-01-04 20:09:37 UTC) #6

Change committed as 116389