Fix build so we can make a Windows SDK!

Fix build so we can make a Windows SDK!
Committed: https://code.google.com/p/dart/source/detail?r=2612

[dgrove, 2011-12-20 01:53:29]

http://codereview.chromium.org/9004001/diff/4008/dart.gyp
File dart.gyp (right):

http://codereview.chromium.org/9004001/diff/4008/dart.gyp#newcode8
dart.gyp:8: 'msvs_cygwin_dirs': ['<(cygwin_dir)'],
not sure where these are being used.

http://codereview.chromium.org/9004001/diff/4008/frog/dart-frog.gyp
File frog/dart-frog.gyp (right):

http://codereview.chromium.org/9004001/diff/4008/frog/dart-frog.gyp#newcode8
frog/dart-frog.gyp:8: 'msvs_cygwin_dirs': ['<(cygwin_dir)'],
ditto.

http://codereview.chromium.org/9004001/diff/4008/frog/frogc.bat
File frog/frogc.bat (right):

http://codereview.chromium.org/9004001/diff/4008/frog/frogc.bat#newcode12
frog/frogc.bat:12: echo "%SCRIPTPATH%\dart.exe --new_gen_heap_size=128
%SCRIPTPATH%\frogc.dart --libdir=%LIBPATH% %*"
this should go away.

http://codereview.chromium.org/9004001/diff/4008/frog/scripts/list_frog_depen...
File frog/scripts/list_frog_dependencies.py (right):

http://codereview.chromium.org/9004001/diff/4008/frog/scripts/list_frog_depen...
frog/scripts/list_frog_dependencies.py:12: print
'../third_party/v8/src/d8.gyp:d8'
Can you add a todo somewhere to reflect the fact that we should have the windows
builds at parity with mac/linux?

[Emily Fortuna, 2011-12-20 02:00:19]

ptal

http://codereview.chromium.org/9004001/diff/4008/dart.gyp
File dart.gyp (right):

http://codereview.chromium.org/9004001/diff/4008/dart.gyp#newcode8
dart.gyp:8: 'msvs_cygwin_dirs': ['<(cygwin_dir)'],
vcproj file. I added a comment. 

On 2011/12/20 01:53:29, dgrove wrote:
> not sure where these are being used.

http://codereview.chromium.org/9004001/diff/4008/frog/frogc.bat
File frog/frogc.bat (right):

http://codereview.chromium.org/9004001/diff/4008/frog/frogc.bat#newcode12
frog/frogc.bat:12: echo "%SCRIPTPATH%\dart.exe --new_gen_heap_size=128
%SCRIPTPATH%\frogc.dart --libdir=%LIBPATH% %*"
On 2011/12/20 01:53:29, dgrove wrote:
> this should go away.

Done.

[Emily Fortuna, 2011-12-20 02:00:22]

ptal

[dgrove, 2011-12-20 02:03:35]

lgtm

[Jennifer Messerly, 2011-12-20 02:09:39]

lgtm

http://codereview.chromium.org/9004001/diff/7001/frog/dart-frog.gyp
File frog/dart-frog.gyp (right):

http://codereview.chromium.org/9004001/diff/7001/frog/dart-frog.gyp#newcode20
frog/dart-frog.gyp:20: '<!@(["python", "scripts/list_frog_dependencies.py"])'
VM is using this syntax to set conditional variables (from vm.gypi). Might be
nice to do something similar. Anyway, since the Python script works, not a big
deal :)

      'conditions': [
        ['OS=="linux"', {
          'link_settings': {
            'libraries': [
              '-lpthread',
              '-lrt',
              '-lcrypto',
            ],
          },
        }],
        ['OS=="mac"', {
          'link_settings': {
            'xcode_settings': {
              'OTHER_LDFLAGS': [
                '-lcrypto',
              ],
            },
          },
        }],
        ['OS=="win"', {
          'sources/' : [
            ['exclude', 'gdbjit.cc'],
          ],
          'link_settings': {
            'libraries': [ '-llibeay32MT.lib' ],
          },
       }]],

http://codereview.chromium.org/9004001/diff/7001/frog/frogc.bat
File frog/frogc.bat (right):

http://codereview.chromium.org/9004001/diff/7001/frog/frogc.bat#newcode9
frog/frogc.bat:9: REM If anyone has a prettier way to truncate after the last \,
I'm all ears.
Usually Windows programs ignore duplicated \\, similar to *nix systems. e.g. on
Mac: 
~/dart/dart/frog$ ls lib//////node
node.dart

so it might be that we need Frog and/or VM to have more graceful path handling.