base::Bind: Convert most of webkit/appcache.

webkit/fileapi/file_system_dir_url_request_job_unittest.cc

Index: webkit/fileapi/file_system_dir_url_request_job_unittest.cc
diff --git a/webkit/fileapi/file_system_dir_url_request_job_unittest.cc b/webkit/fileapi/file_system_dir_url_request_job_unittest.cc
index fb52cd2d453090398545e13ebe39d4a5d80ac052..e4ad540a693da0bef9101b288abcf7d491762de4 100644
--- a/webkit/fileapi/file_system_dir_url_request_job_unittest.cc
+++ b/webkit/fileapi/file_system_dir_url_request_job_unittest.cc
@@ -281,18 +281,11 @@ TEST_F(FileSystemDirURLRequestJobTest, NoSuchDirectory) {
   EXPECT_EQ(net::ERR_FILE_NOT_FOUND, request_->status().error());
 }
 
-class QuitNowTask : public Task {
- public:
-  virtual void Run() {
-    MessageLoop::current()->QuitNow();
-  }
-};
-
 TEST_F(FileSystemDirURLRequestJobTest, Cancel) {
   CreateDirectory("foo");
   TestRequestNoRun(CreateFileSystemURL("foo/"));
   // Run StartAsync() and only StartAsync().
-  MessageLoop::current()->PostTask(FROM_HERE, new QuitNowTask);
+  MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());

[awong, 2011/12/20 23:51:47]

This is a behavior change...I think it breaks the tests?

If I'm reading right, we want to get control back from when StartAsync()
completes, delete request_, and then make sure we don't crash.

I think restructing this test as

TestRequestNoRun(...);
// Enqueue a delete before starting the loop so we can
// test what happens if the request is deleted right
// after StartAsync() is run.
MessageLoop::current()->DeleteSoon(requeust_.release());
MessageLoop::current()->RunAllPending();

is more clear.

[James Hawkins, 2011/12/21 00:43:08]

Done.

   MessageLoop::current()->Run();
 
   request_.reset();