base::Bind: Convert most of webkit/appcache.

webkit/fileapi/file_system_dir_url_request_job_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // NOTE: These tests are run as part of "unit_tests" (in chrome/test/unit)
 // rather than as part of test_shell_tests because they rely on being able
 // to instantiate a MessageLoop of type TYPE_IO.  test_shell_tests uses
 // TYPE_UI, which URLRequest doesn't allow.
 //
 
@@ skipping 263 matching lines @@
   EXPECT_EQ(net::ERR_FILE_NOT_FOUND, request_->status().error());
 }
 
 TEST_F(FileSystemDirURLRequestJobTest, NoSuchDirectory) {
   TestRequest(CreateFileSystemURL("somedir/"));
   ASSERT_FALSE(request_->is_pending());
   ASSERT_FALSE(request_->status().is_success());
   EXPECT_EQ(net::ERR_FILE_NOT_FOUND, request_->status().error());
 }
 
-class QuitNowTask : public Task {
- public:
-  virtual void Run() {
-    MessageLoop::current()->QuitNow();
-  }
-};
-
 TEST_F(FileSystemDirURLRequestJobTest, Cancel) {
   CreateDirectory("foo");
   TestRequestNoRun(CreateFileSystemURL("foo/"));
   // Run StartAsync() and only StartAsync().
-  MessageLoop::current()->PostTask(FROM_HERE, new QuitNowTask);
+  MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());

[awong, 2011/12/20 23:51:47]

This is a behavior change...I think it breaks the tests?

If I'm reading right, we want to get control back from when StartAsync()
completes, delete request_, and then make sure we don't crash.

I think restructing this test as

TestRequestNoRun(...);
// Enqueue a delete before starting the loop so we can
// test what happens if the request is deleted right
// after StartAsync() is run.
MessageLoop::current()->DeleteSoon(requeust_.release());
MessageLoop::current()->RunAllPending();

is more clear.

[James Hawkins, 2011/12/21 00:43:08]

Done.

   MessageLoop::current()->Run();
 
   request_.reset();
   MessageLoop::current()->RunAllPending();
   // If we get here, success! we didn't crash!
 }
 
 }  // namespace (anonymous)
 }  // namespace fileapi