Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 8989011: Undo change that converted exit code 255 to -1. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/process_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index ca1fb7d8d2609b62bf826c75cea0a3a9ede408e4..87553ca0150bcf1b3a2c6a57048a2a25613c7a17 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -127,23 +127,18 @@ class TestOutput {
bool get unexpectedOutput() => !testCase.expectedOutcomes.contains(result);
- // The Java dartc runner exits with code 253 in case of unhandled
- // exceptions.
- // The VM uses std::abort to terminate on asserts.
- // std::abort terminates with exit code 3 on Windows.
bool get hasCrashed() {
if (new Platform().operatingSystem() == 'windows') {
+ // The VM uses std::abort to terminate on asserts.
+ // std::abort terminates with exit code 3 on Windows.
if (exitCode == 3) {
return !timedOut;
}
- return (!timedOut &&
- (exitCode != -1) &&
- (exitCode < 0) &&
- ((0x3FFFFF00 & exitCode) == 0));
+ return (!timedOut && (exitCode < 0) && ((0x3FFFFF00 & exitCode) == 0));
}
- return (!timedOut &&
- (exitCode != -1) &&
- ((exitCode < 0) || (exitCode == 253)));
+ // The Java dartc runner exits with code 253 in case of unhandled
+ // exceptions.
+ return (!timedOut && ((exitCode < 0) || (exitCode == 253)));
}
bool get hasTimedOut() => timedOut;
« no previous file with comments | « runtime/bin/process_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698