runtime/bin/process_win.cc - Issue 8989011: Undo change that converted exit code 255 to -1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/process_win.cc

Issue 8989011: Undo change that converted exit code 255 to -1. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/process_win.cc

diff --git a/runtime/bin/process_win.cc b/runtime/bin/process_win.cc

index 965f43728f3ac6f7a969fdc785f5cc9bc9180c9f..64095c6f1930735fc7559aa7593451c7d1a9de87 100644

--- a/runtime/bin/process_win.cc

+++ b/runtime/bin/process_win.cc

@@ -211,10 +211,6 @@ static unsigned int __stdcall TerminationWaitThread(void* args) {

fprintf(stderr, "GetExitCodeProcess failed %d\n", GetLastError());

}

int negative = 0;

- if (exit_code == 255) {

- exit_code = 1;

- negative = 1;

- }

if (exit_code < 0) {

exit_code = abs(exit_code);

negative = 1;

« no previous file with comments | « runtime/bin/process_macos.cc ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »