chromeos: Implement power button animations for Aura.

chromeos: Implement power button animations for Aura.

This adds animated transitions first to the lock screen and
then to shutdown similar to those currently implemented in
the Chrome OS power manager and X window manager.  I'll add
support for the lock key in a later change.

BUG=98328
TEST=added tests; also did a lot of manual testing
TBR=evan@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116245

[Daniel Erat, 2011-12-29 01:05:14]

This change got sort of big.  At least it has tests?

Steven: chrome/browser/chromeos/
Ben: everything else

[Ben Goodger (Google), 2012-01-03 17:03:42]

You probably need a base owner for the comment change there to satisfy the
owners check.

LGTM.

[stevenjb, 2012-01-03 17:05:41]

lgtm with nit

http://codereview.chromium.org/8976012/diff/12001/chrome/browser/chromeos/pow...
File chrome/browser/chromeos/power/power_button_observer.cc (right):

http://codereview.chromium.org/8976012/diff/12001/chrome/browser/chromeos/pow...
chrome/browser/chromeos/power/power_button_observer.cc:38:
user_manager->logged_in_user().email() == UserManager::kGuestUser;
nit: I think it might be worth adding User::IsGuest() to avoid exposing this
implementation detail here and below.

[Daniel Erat, 2012-01-03 19:12:12]

http://codereview.chromium.org/8976012/diff/12001/chrome/browser/chromeos/pow...
File chrome/browser/chromeos/power/power_button_observer.cc (right):

http://codereview.chromium.org/8976012/diff/12001/chrome/browser/chromeos/pow...
chrome/browser/chromeos/power/power_button_observer.cc:38:
user_manager->logged_in_user().email() == UserManager::kGuestUser;
On 2012/01/03 17:05:41, stevenjb (chromium) wrote:
> nit: I think it might be worth adding User::IsGuest() to avoid exposing this
> implementation detail here and below.

Thanks, I agree.  Done (by adding an is_guest_ field to the User class -- let me
know if you think that it'd be cleaner to move the kGuestUser constant to the
User class and just compare the email address against it instead).

[stevenjb, 2012-01-03 19:26:48]

LGTM
Storing is_guest_ explicitly in User seems best to me.