Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: frog/leg/tree/nodes.dart

Issue 8974014: Resolve initializers in constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Don't call function that does not exist. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/leg/tree/nodes.dart
diff --git a/frog/leg/tree/nodes.dart b/frog/leg/tree/nodes.dart
index 17f87eab9734a7d93584e1c51a5456b4c6471f31..cd3b1abbe96ddaa0bd95cd1b38e0e0760bfaee8d 100644
--- a/frog/leg/tree/nodes.dart
+++ b/frog/leg/tree/nodes.dart
@@ -251,6 +251,18 @@ class SendSet extends Send {
Send copyWithReceiver(Node receiver) {
throw 'not implemented';
}
+
+ bool isInitializer() {
ngeoffray 2011/12/21 11:52:11 Not sure I understand: how can you be sure a SendS
karlklose 2011/12/21 16:33:46 Done, moved the helpers.
+ if (selector.asIdentifier() == null) return false;
+ if (receiver == null) return true;
+ return receiver.asIdentifier() != null;
+ return receiver.asIdentifier().source.stringValue() == 'this';
ahe 2011/12/21 12:01:58 == -> === Also, stringValue is a getter, not a fu
karlklose 2011/12/21 16:33:46 Done.
+ }
+
+ SourceString getInitializerFieldName(errorHandler()) {
ahe 2011/12/21 12:01:58 How about "onError" instead of "errorHandler"?
karlklose 2011/12/21 16:33:46 Done.
+ if (!isInitializer()) errorHandler();
+ return selector.asIdentifier().source;
+ }
}
class NewExpression extends Expression {

Powered by Google App Engine
This is Rietveld 408576698