Resolve initializers in constructors.

frog/leg/tree/nodes.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface Visitor<R> {
   R visitBlock(Block node);
   R visitClassNode(ClassNode node);
   R visitConditional(Conditional node);
   R visitDoWhile(DoWhile node);
   R visitExpressionStatement(ExpressionStatement node);
@@ skipping 233 matching lines @@
   accept(Visitor visitor) => visitor.visitSendSet(this);
 
   visitChildren(Visitor visitor) {
     super.visitChildren(visitor);
     if (assignmentOperator !== null) assignmentOperator.accept(visitor);
   }
 
   Send copyWithReceiver(Node receiver) {
     throw 'not implemented';
   }
+
+  bool isInitializer() {

[ngeoffray, 2011/12/21 11:52:11]

Not sure I understand: how can you be sure a SendSet is in an initializer list?
Or are you using 'initializer' for any kind of variable initialization?

In any case, I think these helper methods belong to the resolver. The helpers
that I would put on a SendSet are get lhs() and get rhs().

[karlklose, 2011/12/21 16:33:46]

Done, moved the helpers.

+    if (selector.asIdentifier() == null) return false;
+    if (receiver == null) return true;
+    return receiver.asIdentifier() != null;
+    return receiver.asIdentifier().source.stringValue() == 'this';

[ahe, 2011/12/21 12:01:58]

== -> ===

Also, stringValue is a getter, not a function.

Also, this is dead code. You have two return statements. Did you mean &&?

[karlklose, 2011/12/21 16:33:46]

Done.

+  }
+
+  SourceString getInitializerFieldName(errorHandler()) {

[ahe, 2011/12/21 12:01:58]

How about "onError" instead of "errorHandler"?

[karlklose, 2011/12/21 16:33:46]

Done.

+    if (!isInitializer()) errorHandler();
+    return selector.asIdentifier().source;
+  }
 }
 
 class NewExpression extends Expression {
   /** The token NEW or CONST */
   final Token newToken;
 
   // Note: we expect that send.receiver is null.
   final Send send;
 
   NewExpression([this.newToken, this.send]);
@@ skipping 632 matching lines @@
 
   UnimplementedStatement(this.description, List<Node> nodes)
     : this.nodes = new NodeList(null, new Link<Node>.fromList(nodes));
 
   toString() => '$description($nodes)';
 
   Token getBeginToken() => nodes.getBeginToken();
 
   Token getEndToken() => nodes.getEndToken();
 }