Fix file leaks in a ETW test and a ScopedTempDir test.

Fix file leaks in a ETW test and a ScopedTempDir test.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115036

[Lei Zhang, 2011-12-16 02:08:08]

Whoops, we've been leaking files in this test for 2 years. @_@

[Lei Zhang, 2011-12-16 02:20:16]

On 2011/12/16 02:08:08, Lei Zhang wrote:
> Whoops, we've been leaking files in this test for 2 years. @_@

Fix a second base_unittest leak while we are at it.

[Sigurður Ásgeirsson, 2011-12-16 13:59:44]

http://codereview.chromium.org/8972009/diff/4001/base/scoped_temp_dir_unittes...
File base/scoped_temp_dir_unittest.cc (right):

http://codereview.chromium.org/8972009/diff/4001/base/scoped_temp_dir_unittes...
base/scoped_temp_dir_unittest.cc:78: file_util::Delete(base_path, true);
how ironic :).

http://codereview.chromium.org/8972009/diff/4001/base/win/event_trace_control...
File base/win/event_trace_controller_unittest.cc (right):

http://codereview.chromium.org/8972009/diff/4001/base/win/event_trace_control...
base/win/event_trace_controller_unittest.cc:144:
ASSERT_HRESULT_SUCCEEDED(file_util::CreateTemporaryFile(&temp));
can this be a ScopedTempDir instead?

[Nico, 2011-12-16 16:29:05]

LGTM, nice find :-)

http://codereview.chromium.org/8972009/diff/4001/base/scoped_temp_dir_unittes...
File base/scoped_temp_dir_unittest.cc (right):

http://codereview.chromium.org/8972009/diff/4001/base/scoped_temp_dir_unittes...
base/scoped_temp_dir_unittest.cc:78: file_util::Delete(base_path, true);
On 2011/12/16 13:59:45, Ruðrugis wrote:
> how ironic :).

+1

[Lei Zhang, 2011-12-16 20:00:21]

Nothing too controversial, so I'll click the commit box now.

http://codereview.chromium.org/8972009/diff/4001/base/win/event_trace_control...
File base/win/event_trace_controller_unittest.cc (right):

http://codereview.chromium.org/8972009/diff/4001/base/win/event_trace_control...
base/win/event_trace_controller_unittest.cc:144:
ASSERT_HRESULT_SUCCEEDED(file_util::CreateTemporaryFile(&temp));
On 2011/12/16 13:59:45, Ruðrugis wrote:
> can this be a ScopedTempDir instead?

Sure, in patch set 3.

[commit-bot: I haz the power, 2011-12-16 20:00:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8972009/8001

[commit-bot: I haz the power, 2011-12-16 23:25:20]

Try job failure for 8972009-8001 (retry) (retry) on win_rel for step
"unit_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-12-16 23:50:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8972009/8001

[commit-bot: I haz the power, 2011-12-17 00:50:26]

Try job failure for 8972009-8001 (retry) on linux_rel for step "check_deps".
It's a second try, previously, step "check_deps" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[Sigurður Ásgeirsson, 2011-12-17 15:04:00]

Thanks!

On Fri, Dec 16, 2011 at 15:00, <thestig@chromium.org> wrote:

> Nothing too controversial, so I'll click the commit box now.
>
>
>
> http://codereview.chromium.**org/8972009/diff/4001/base/**
>
win/event_trace_controller_**unittest.cc<http://codereview.chromium.org/8972009/diff/4001/base/win/event_trace_controller_unittest.cc>
> File base/win/event_trace_**controller_unittest.cc (right):
>
> http://codereview.chromium.**org/8972009/diff/4001/base/**
>
win/event_trace_controller_**unittest.cc#newcode144<http://codereview.chromium.org/8972009/diff/4001/base/win/event_trace_controller_unittest.cc#newcode144>
> base/win/event_trace_**controller_unittest.cc:144:
> ASSERT_HRESULT_SUCCEEDED(file_**util::CreateTemporaryFile(&**temp));
> On 2011/12/16 13:59:45, Ruðrugis wrote:
>
>> can this be a ScopedTempDir instead?
>>
>
> Sure, in patch set 3.
>
>
http://codereview.chromium.**org/8972009/<http://codereview.chromium.org/8972...
>

[commit-bot: I haz the power, 2011-12-19 21:10:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/8972009/8001

[commit-bot: I haz the power, 2011-12-19 23:24:11]

Change committed as 115036