Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: base/win/event_trace_controller_unittest.cc

Issue 8972009: Fix file leaks in a ETW test and a ScopedTempDir test. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/scoped_temp_dir_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Unit tests for event trace controller. 5 // Unit tests for event trace controller.
6 6
7 #include <initguid.h> // NOLINT. 7 #include <initguid.h> // NOLINT.
8 8
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
11 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/scoped_temp_dir.h"
12 #include "base/sys_info.h" 13 #include "base/sys_info.h"
13 #include "base/win/event_trace_controller.h" 14 #include "base/win/event_trace_controller.h"
14 #include "base/win/event_trace_provider.h" 15 #include "base/win/event_trace_provider.h"
15 #include "base/win/scoped_handle.h" 16 #include "base/win/scoped_handle.h"
16 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
17 18
18 namespace { 19 namespace {
19 20
20 using base::win::EtwTraceController; 21 using base::win::EtwTraceController;
21 using base::win::EtwTraceProvider; 22 using base::win::EtwTraceProvider;
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 133
133 EXPECT_TRUE(NULL != controller.session()); 134 EXPECT_TRUE(NULL != controller.session());
134 EXPECT_STREQ(kTestSessionName, controller.session_name()); 135 EXPECT_STREQ(kTestSessionName, controller.session_name());
135 136
136 EXPECT_HRESULT_SUCCEEDED(controller.Stop(NULL)); 137 EXPECT_HRESULT_SUCCEEDED(controller.Stop(NULL));
137 EXPECT_EQ(NULL, controller.session()); 138 EXPECT_EQ(NULL, controller.session());
138 EXPECT_STREQ(L"", controller.session_name()); 139 EXPECT_STREQ(L"", controller.session_name());
139 } 140 }
140 141
141 TEST(EtwTraceControllerTest, StartFileSession) { 142 TEST(EtwTraceControllerTest, StartFileSession) {
143 ScopedTempDir temp_dir;
144 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
142 FilePath temp; 145 FilePath temp;
143 146 ASSERT_TRUE(file_util::CreateTemporaryFileInDir(temp_dir.path(), &temp));
144 ASSERT_HRESULT_SUCCEEDED(file_util::CreateTemporaryFile(&temp));
145 147
146 EtwTraceController controller; 148 EtwTraceController controller;
147 HRESULT hr = controller.StartFileSession(kTestSessionName, 149 HRESULT hr = controller.StartFileSession(kTestSessionName,
148 temp.value().c_str()); 150 temp.value().c_str());
149 if (hr == E_ACCESSDENIED) { 151 if (hr == E_ACCESSDENIED) {
150 VLOG(1) << "You must be an administrator to run this test on Vista"; 152 VLOG(1) << "You must be an administrator to run this test on Vista";
153 file_util::Delete(temp, false);
151 return; 154 return;
152 } 155 }
153 156
154 EXPECT_TRUE(NULL != controller.session()); 157 EXPECT_TRUE(NULL != controller.session());
155 EXPECT_STREQ(kTestSessionName, controller.session_name()); 158 EXPECT_STREQ(kTestSessionName, controller.session_name());
156 159
157 EXPECT_HRESULT_SUCCEEDED(controller.Stop(NULL)); 160 EXPECT_HRESULT_SUCCEEDED(controller.Stop(NULL));
158 EXPECT_EQ(NULL, controller.session()); 161 EXPECT_EQ(NULL, controller.session());
159 EXPECT_STREQ(L"", controller.session_name()); 162 EXPECT_STREQ(L"", controller.session_name());
163 file_util::Delete(temp, false);
160 } 164 }
161 165
162 TEST(EtwTraceControllerTest, EnableDisable) { 166 TEST(EtwTraceControllerTest, EnableDisable) {
163 TestingProvider provider(kTestProvider); 167 TestingProvider provider(kTestProvider);
164 168
165 EXPECT_EQ(ERROR_SUCCESS, provider.Register()); 169 EXPECT_EQ(ERROR_SUCCESS, provider.Register());
166 EXPECT_EQ(NULL, provider.session_handle()); 170 EXPECT_EQ(NULL, provider.session_handle());
167 171
168 EtwTraceController controller; 172 EtwTraceController controller;
169 HRESULT hr = controller.StartRealtimeSession(kTestSessionName, 100 * 1024); 173 HRESULT hr = controller.StartRealtimeSession(kTestSessionName, 100 * 1024);
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 EXPECT_EQ(kTestProviderFlags, provider.enable_flags()); 205 EXPECT_EQ(kTestProviderFlags, provider.enable_flags());
202 206
203 EXPECT_HRESULT_SUCCEEDED(controller.Stop(NULL)); 207 EXPECT_HRESULT_SUCCEEDED(controller.Stop(NULL));
204 208
205 provider.WaitForCallback(); 209 provider.WaitForCallback();
206 210
207 // Session should have wound down. 211 // Session should have wound down.
208 EXPECT_EQ(0, provider.enable_level()); 212 EXPECT_EQ(0, provider.enable_level());
209 EXPECT_EQ(0, provider.enable_flags()); 213 EXPECT_EQ(0, provider.enable_flags());
210 } 214 }
OLDNEW
« no previous file with comments | « base/scoped_temp_dir_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698