Issue 897003: set resource loading path relative to the executable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 897003: set resource loading path relative to the executable (Closed)

Created:
10 years, 9 months ago by piman

Modified:
9 years, 7 months ago

Reviewers:
Alexey Marinichev, amarinichev

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

set resource loading path relative to the executable

Patch Set 1 #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -2 lines)			Patch
M	client/deps/glbench/src/main.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	client/deps/glbench/src/utils.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	client/deps/glbench/src/utils.cc	View	1 chunk	+16 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

piman

Note: this depends on http://codereview.chromium.org/862004

10 years, 9 months ago (2010-03-12 03:49:00 UTC) #1

Alexey Marinichev

LGTM except for couple spaces. http://codereview.chromium.org/897003/diff/1/3 File client/deps/glbench/src/utils.cc (right): http://codereview.chromium.org/897003/diff/1/3#newcode20 client/deps/glbench/src/utils.cc:20: void SetBasePathFromArgv0(const char* argv0, ...

10 years, 9 months ago (2010-03-12 19:22:59 UTC) #2

piman

10 years, 9 months ago (2010-03-12 19:29:31 UTC) #3

On 2010/03/12 19:22:59, Alexey Marinichev wrote:
> LGTM except for couple spaces.
> 
> http://codereview.chromium.org/897003/diff/1/3
> File client/deps/glbench/src/utils.cc (right):
> 
> http://codereview.chromium.org/897003/diff/1/3#newcode20
> client/deps/glbench/src/utils.cc:20: void SetBasePathFromArgv0(const char*
> argv0, const char* relative) {
> Everywhere else, including line 17, pointers are declared with space before
> star.
> 
> http://codereview.chromium.org/897003/diff/1/3#newcode29
> client/deps/glbench/src/utils.cc:29: void *MmapFile(const char* name, size_t*
> length) {
> Same thing here.

http://dev.chromium.org/developers/coding-style
stars go on the left in chromium code.

Expand Messages | Collapse Messages