refactoring mouse lock to support pepper and WebKit

webkit/plugins/ppapi/ppapi_plugin_instance.h

Index: webkit/plugins/ppapi/ppapi_plugin_instance.h
diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.h b/webkit/plugins/ppapi/ppapi_plugin_instance.h
index 3caef5cbc8d7e4261eb17c91bfd65a449b18496d..896aa2663f027215d957697ef4f145eb82361679 100644
--- a/webkit/plugins/ppapi/ppapi_plugin_instance.h
+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.h
@@ -51,6 +51,7 @@ class TransportDIB;
 
 namespace WebKit {
 class WebInputEvent;
+class WebMouseEvent;
 class WebPluginContainer;
 struct WebCompositionUnderline;
 struct WebCursorInfo;
@@ -301,8 +302,12 @@ class WEBKIT_PLUGINS_EXPORT PluginInstance :
   // or embedded in a page).
   bool IsFullPagePlugin() const;
 
-  void OnLockMouseACK(int32_t result);
-  void OnMouseLockLost();
+  // A mouse lock request was pending, and the success is being returned.
+  virtual void OnLockMouseACK(bool success);

[yzshen1, 2012/01/16 07:50:35]

Why the three methods need to be virtual?

the success -> the result.

[scheib, 2012/01/17 22:05:36]

Done.

+  // A mouse lock was in place, but has been lost

[yzshen1, 2012/01/16 07:50:35]

Please add a period, please.

[scheib, 2012/01/17 22:05:36]

Done.

+  virtual void OnMouseLockLost();
+  // A mouse lock is enabled and mouse events are being delievered.
+  virtual void HandleMouseLockedInputEvent(const WebKit::WebMouseEvent& event);
 
   // Simulates an input event to the plugin by passing it down to WebKit,
   // which sends it back up to the plugin as if it came from the user.