refactoring mouse lock to support pepper and WebKit

webkit/plugins/ppapi/ppapi_plugin_instance.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
 #define WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 33 matching lines @@
 #include "webkit/plugins/ppapi/ppp_pdf.h"
 #include "webkit/plugins/webkit_plugins_export.h"
 
 struct PP_Point;
 
 class SkBitmap;
 class TransportDIB;
 
 namespace WebKit {
 class WebInputEvent;
+class WebMouseEvent;
 class WebPluginContainer;
 struct WebCompositionUnderline;
 struct WebCursorInfo;
 }
 
 namespace ppapi {
 struct InputEventData;
 struct PPP_Instance_Combined;
 class Resource;
 }
@@ skipping 230 matching lines @@
 
   // Implementation of PPP_Messaging.
   void HandleMessage(PP_Var message);
 
   PluginDelegate::PlatformContext3D* CreateContext3D();
 
   // Returns true iff the plugin is a full-page plugin (i.e. not in an iframe
   // or embedded in a page).
   bool IsFullPagePlugin() const;
 
-  void OnLockMouseACK(int32_t result);
-  void OnMouseLockLost();
+  // A mouse lock request was pending, and the success is being returned.
+  virtual void OnLockMouseACK(bool success);

[yzshen1, 2012/01/16 07:50:35]

Why the three methods need to be virtual?

the success -> the result.

[scheib, 2012/01/17 22:05:36]

Done.

+  // A mouse lock was in place, but has been lost

[yzshen1, 2012/01/16 07:50:35]

Please add a period, please.

[scheib, 2012/01/17 22:05:36]

Done.

+  virtual void OnMouseLockLost();
+  // A mouse lock is enabled and mouse events are being delievered.
+  virtual void HandleMouseLockedInputEvent(const WebKit::WebMouseEvent& event);
 
   // Simulates an input event to the plugin by passing it down to WebKit,
   // which sends it back up to the plugin as if it came from the user.
   void SimulateInputEvent(const ::ppapi::InputEventData& input_event);
 
   // FunctionGroupBase overrides.
   virtual ::ppapi::thunk::PPB_Instance_FunctionAPI*
       AsPPB_Instance_FunctionAPI() OVERRIDE;
 
   // PPB_Instance_FunctionAPI implementation.
@@ skipping 295 matching lines @@
 
   PP_CompletionCallback lock_mouse_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginInstance);
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_