Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: client/testing/unittest/unittest_dartest.dart

Issue 8966029: Report errors and warnings for hiding elements, issue 572. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes for comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/testing/unittest/unittest.dart ('k') | client/tests/client/html/DocumentFragmentTests.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/testing/unittest/unittest_dartest.dart
diff --git a/client/testing/unittest/unittest_dartest.dart b/client/testing/unittest/unittest_dartest.dart
index c60144628ae9bc97eb4ba976b291b5b860d069e1..b92ae8cdb99aa7f1291ed99355d3915d9f4bdb37 100644
--- a/client/testing/unittest/unittest_dartest.dart
+++ b/client/testing/unittest/unittest_dartest.dart
@@ -31,17 +31,17 @@ _platformDefer(void callback()) {
}
// Update test results
-updateTestStats(TestCase test) {
- assert(test.result != null);
- if(test.startTime != null) {
- test.runningTime = (new Date.now()).difference(test.startTime);
+updateTestStats(TestCase test_) {
+ assert(test_.result != null);
+ if(test_.startTime != null) {
+ test_.runningTime = (new Date.now()).difference(test_.startTime);
}
testsRun++;
- switch (test.result) {
+ switch (test_.result) {
case 'fail': testsFailed++; break;
case 'error': testsErrors++; break;
}
- updateUI(test);
+ updateUI(test_);
}
// Run tests sequentially
@@ -74,18 +74,18 @@ _platformInitialize() {
// Do nothing
}
-_platformCompleteTests(int testsPassed, int testsFailed, int testsErrors) {
+_platformCompleteTests(int testsPassed_, int testsFailed_, int testsErrors_) {
// Do nothing
}
String getTestResultsCsv() {
StringBuffer out = new StringBuffer();
- _tests.forEach((final test) {
+ _tests.forEach((final test_) {
String result = 'none';
- if(test.result != null) {
- result = test.result.toUpperCase();
+ if(test_.result != null) {
+ result = test_.result.toUpperCase();
}
- out.add('${test.id}, "${test.description}", $result\n');
+ out.add('${test_.id}, "${test_.description}", $result\n');
});
return out.toString();
}
« no previous file with comments | « client/testing/unittest/unittest.dart ('k') | client/tests/client/html/DocumentFragmentTests.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698