Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: client/layout/GridLayout.dart

Issue 8966029: Report errors and warnings for hiding elements, issue 572. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fixes for comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/html/release/htmlimpl.dart ('k') | client/samples/dartcombat/state.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/layout/GridLayout.dart
diff --git a/client/layout/GridLayout.dart b/client/layout/GridLayout.dart
index 32006f1c10aab151c2b752bf360e64c8be49d0da..a3688a84dd68a0e13a3ca2f657ad9f7b66d8f0ff 100644
--- a/client/layout/GridLayout.dart
+++ b/client/layout/GridLayout.dart
@@ -152,7 +152,7 @@ class GridLayout extends ViewLayout {
void _computeUsedBreadthOfTracks(List<GridTrack> tracks) {
// TODO(jmesserly): as a performance optimization we could cache this
- final items = CollectionUtils.map(view.childViews, (view) => view.layout);
+ final items = CollectionUtils.map(view.childViews, (view_) => view_.layout);
CollectionUtils.sortBy(items, (item) => _getSpanCount(item));
// 1. Initialize per Grid Track variables
@@ -385,7 +385,7 @@ class GridLayout extends ViewLayout {
sizeMode == ContentSizeMode.MIN && fn.isContentSized) {
// Make sure we don't cross a fractional track
- return tracks.length == 1 || !tracks.some((t) => t.isFractional);
+ return tracks.length == 1 || !tracks.some((t_) => t_.isFractional);
}
}
return false;
@@ -418,7 +418,7 @@ class GridLayout extends ViewLayout {
* run before the track sizing algorithm.
*/
void _ensureAllTracks() {
- final items = CollectionUtils.map(view.childViews, (view) => view.layout);
+ final items = CollectionUtils.map(view.childViews, (view_) => view_.layout);
for (final child in items) {
if (child.layoutParams == null) {
@@ -435,7 +435,7 @@ class GridLayout extends ViewLayout {
* Given the track sizes that were computed, position children in the grid.
*/
void _setBoundsOfChildren() {
- final items = CollectionUtils.map(view.childViews, (view) => view.layout);
+ final items = CollectionUtils.map(view.childViews, (view_) => view_.layout);
for (final item in items) {
GridLayoutParams childLayout = item.layoutParams;
« no previous file with comments | « client/html/release/htmlimpl.dart ('k') | client/samples/dartcombat/state.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698