Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 8965038: Clean up handling of global cell stores in the optimizing compiler. (Closed)

Created:
9 years ago by Kevin Millikin (Chromium)
Modified:
9 years ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Clean up handling of global cell stores in the optimizing compiler. Tell the register allocator the value is not overwritten. Never use temporary registers on ia32, avoid them on x64 and ARM. Restore the original copyright date on assembler.cc. R=fschneider@chromium.org BUG=v8:1870 TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -52 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +13 lines, -11 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years ago (2011-12-20 10:08:54 UTC) #1
fschneider
9 years ago (2011-12-20 10:31:19 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698