Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 8965038: Clean up handling of global cell stores in the optimizing compiler. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1838 matching lines...) Expand 10 before | Expand all | Expand 10 after
1849 LOperand* context = UseFixed(instr->context(), esi); 1849 LOperand* context = UseFixed(instr->context(), esi);
1850 LOperand* global_object = UseFixed(instr->global_object(), eax); 1850 LOperand* global_object = UseFixed(instr->global_object(), eax);
1851 LLoadGlobalGeneric* result = 1851 LLoadGlobalGeneric* result =
1852 new(zone()) LLoadGlobalGeneric(context, global_object); 1852 new(zone()) LLoadGlobalGeneric(context, global_object);
1853 return MarkAsCall(DefineFixed(result, eax), instr); 1853 return MarkAsCall(DefineFixed(result, eax), instr);
1854 } 1854 }
1855 1855
1856 1856
1857 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) { 1857 LInstruction* LChunkBuilder::DoStoreGlobalCell(HStoreGlobalCell* instr) {
1858 LStoreGlobalCell* result = 1858 LStoreGlobalCell* result =
1859 new(zone()) LStoreGlobalCell(UseTempRegister(instr->value()), 1859 new(zone()) LStoreGlobalCell(UseRegister(instr->value()));
1860 TempRegister(),
1861 TempRegister());
1862 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result; 1860 return instr->RequiresHoleCheck() ? AssignEnvironment(result) : result;
1863 } 1861 }
1864 1862
1865 1863
1866 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) { 1864 LInstruction* LChunkBuilder::DoStoreGlobalGeneric(HStoreGlobalGeneric* instr) {
1867 LOperand* context = UseFixed(instr->context(), esi); 1865 LOperand* context = UseFixed(instr->context(), esi);
1868 LOperand* global_object = UseFixed(instr->global_object(), edx); 1866 LOperand* global_object = UseFixed(instr->global_object(), edx);
1869 LOperand* value = UseFixed(instr->value(), eax); 1867 LOperand* value = UseFixed(instr->value(), eax);
1870 LStoreGlobalGeneric* result = 1868 LStoreGlobalGeneric* result =
1871 new(zone()) LStoreGlobalGeneric(context, global_object, value); 1869 new(zone()) LStoreGlobalGeneric(context, global_object, value);
(...skipping 505 matching lines...) Expand 10 before | Expand all | Expand 10 after
2377 LOperand* key = UseOrConstantAtStart(instr->key()); 2375 LOperand* key = UseOrConstantAtStart(instr->key());
2378 LOperand* object = UseOrConstantAtStart(instr->object()); 2376 LOperand* object = UseOrConstantAtStart(instr->object());
2379 LIn* result = new(zone()) LIn(context, key, object); 2377 LIn* result = new(zone()) LIn(context, key, object);
2380 return MarkAsCall(DefineFixed(result, eax), instr); 2378 return MarkAsCall(DefineFixed(result, eax), instr);
2381 } 2379 }
2382 2380
2383 2381
2384 } } // namespace v8::internal 2382 } } // namespace v8::internal
2385 2383
2386 #endif // V8_TARGET_ARCH_IA32 2384 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698