views: Convert IsFocusable() to just focusable() since it's just a simple accessor.

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index 139b5d9abac1dac9e056b0eecdb89153177ccea1..0d3e6d58f3b0447cfe0d7b5f253a19cf9fca1f89 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -71,10 +71,10 @@ class AutocompleteTextfield : public views::Textfield {
     return omnibox_view_->HandleKeyReleaseEvent(event);
   }
 
-  virtual bool IsFocusable() const OVERRIDE {
+  virtual bool IsFocusableInRootView() const OVERRIDE {

[Ben Goodger (Google), 2011/12/16 16:20:23]

Questions:

When you open a popup window (www.popuptest.com)
- can you still select text in the omnibox?
- what if you remove this function? can you still select?

     // Bypass Textfield::IsFocusable. The omnibox in popup window requires
     // focus in order for text selection to work.
-    return views::View::IsFocusable();
+    return views::View::focusable();
   }
 
   virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE {