views: Convert IsFocusable() to just focusable() since it's just a simple accessor.

chrome/browser/ui/views/omnibox/omnibox_view_views.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/omnibox/omnibox_view_views.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 53 matching lines @@
 
   virtual bool OnKeyPressed(const views::KeyEvent& event) OVERRIDE {
     bool handled = views::Textfield::OnKeyPressed(event);
     return omnibox_view_->HandleAfterKeyEvent(event, handled) || handled;
   }
 
   virtual bool OnKeyReleased(const views::KeyEvent& event) OVERRIDE {
     return omnibox_view_->HandleKeyReleaseEvent(event);
   }
 
-  virtual bool IsFocusable() const OVERRIDE {
+  virtual bool IsFocusableInRootView() const OVERRIDE {

[Ben Goodger (Google), 2011/12/16 16:20:23]

Questions:

When you open a popup window (www.popuptest.com)
- can you still select text in the omnibox?
- what if you remove this function? can you still select?

     // Bypass Textfield::IsFocusable. The omnibox in popup window requires
     // focus in order for text selection to work.
-    return views::View::IsFocusable();
+    return views::View::focusable();
   }
 
   virtual bool OnMousePressed(const views::MouseEvent& event) OVERRIDE {
     return omnibox_view_->HandleMousePressEvent(event);
   }
 
  private:
   OmniboxViewViews* omnibox_view_;
 
   DISALLOW_COPY_AND_ASSIGN(AutocompleteTextfield);
@@ skipping 687 matching lines @@
   OmniboxViewViews* omnibox_view = new OmniboxViewViews(controller,
                                                         toolbar_model,
                                                         profile,
                                                         command_updater,
                                                         popup_window_mode,
                                                         location_bar);
   omnibox_view->Init();
   return omnibox_view;
 }
 #endif