Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8957001: [Sync] Remove ModelChangingSyncerCommand::HasCustomGroups() (Closed)

Created:
9 years ago by akalin
Modified:
9 years ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

[Sync] Remove ModelChangingSyncerCommand::HasCustomGroups() Now that we've tracked down the root cause for the perf regressions triggered by custom groups, we can remove this function now. BUG=97832, 107040 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114696

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -46 lines) Patch
M chrome/browser/sync/engine/apply_updates_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/apply_updates_command.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/build_and_process_conflict_sets_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/model_changing_syncer_command.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/sync/engine/model_changing_syncer_command.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/engine/model_changing_syncer_command_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/process_commit_response_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/process_commit_response_command.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/process_updates_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/process_updates_command.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/resolve_conflicts_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/resolve_conflicts_command.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/verify_updates_command.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/verify_updates_command.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
akalin
+zea for review
9 years ago (2011-12-15 01:26:53 UTC) #1
Nicolas Zea
lgtm
9 years ago (2011-12-15 18:55:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/8957001/1
9 years ago (2011-12-15 19:17:40 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-15 21:00:38 UTC) #4 
Change committed as 114696

Powered by Google App Engine
This is Rietveld 408576698