Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: chrome/browser/sync/engine/model_changing_syncer_command.h

Issue 8957001: [Sync] Remove ModelChangingSyncerCommand::HasCustomGroups() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/model_changing_syncer_command.h
diff --git a/chrome/browser/sync/engine/model_changing_syncer_command.h b/chrome/browser/sync/engine/model_changing_syncer_command.h
index 2c747530936160157efe18d566377ae5fd6b9cf5..e6f6ca199ec7f8bbdeba9e4f561046024ab9f859 100644
--- a/chrome/browser/sync/engine/model_changing_syncer_command.h
+++ b/chrome/browser/sync/engine/model_changing_syncer_command.h
@@ -48,15 +48,6 @@ class ModelChangingSyncerCommand : public SyncerCommand {
}
protected:
- // Hack to track down which subclass triggers the perf regression.
- // (See comments in http://codereview.chromium.org/8637006/ for
- // details.) If this returns false (the default),
- // GetGroupsToChange() is not used and session.GetEnabledGroups()
- // is used instead.
- //
- // TODO(akalin): Remove this when we track down the perf regression.
- virtual bool HasCustomGroupsToChange() const = 0;
-
// This should return the set of groups in |session| that need to be
// changed. The returned set should be a subset of
// session.GetEnabledGroups(). Subclasses can guarantee this either

Powered by Google App Engine
This is Rietveld 408576698