Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8956059: Rename NavigationController to NavigationControllerImpl and put it into the content namespace. Al... (Closed)

Created:
8 years, 12 months ago by jam
Modified:
8 years, 12 months ago
Reviewers:
joi, Jói
CC:
chromium-reviews, jstritar+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, akalin, ncarter (slow), Raghu Simha, ajwong+watch_chromium.org, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, Paweł Hajdan Jr., darin-cc_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org, kkania, robertshield, tim (not reviewing)
Visibility:
Public.

Description

Rename NavigationController to NavigationControllerImpl and put it into the content namespace. Also make all users of content::NavigationController interface use the "using" keyword so they don't have to put content:: everywhere (similar to other Content API and WebKit API classes). BUG=98716 TBR=joi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115916

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+618 lines, -1138 lines) Patch
M chrome/browser/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_navigation_observer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_page_actions_module.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_url_rewrite_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_handler.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/favicon/favicon_handler_unittest.cc View 1 5 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_settings_state_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/infobars/infobar_delegate.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_loader.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/memory_details.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/omnibox_search_hint.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/rlz/rlz.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/rlz/rlz_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/malware_details.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sessions/base_session_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_types.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 10 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/tabs/pinned_tab_codec.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/tabs/tab_finder.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/translate/options_menu_model.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_infobar_delegate.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_manager.cc View 7 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 12 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search_engines/search_engine_tab_helper.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/sync/tab_contents_wrapper_synced_tab_delegate.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 7 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/click_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/cloud_print_signin_dialog.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/save_package.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/site_instance_unittest.cc View 4 chunks +13 lines, -15 lines 0 comments Download
M content/browser/ssl/ssl_manager.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/ssl/ssl_manager.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M content/browser/ssl/ssl_policy.h View 4 chunks +8 lines, -4 lines 0 comments Download
M content/browser/ssl/ssl_policy.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M content/browser/tab_contents/navigation_controller.h View 11 chunks +13 lines, -11 lines 0 comments Download
M content/browser/tab_contents/navigation_controller.cc View 37 chunks +65 lines, -68 lines 0 comments Download
M content/browser/tab_contents/navigation_controller_unittest.cc View 24 chunks +37 lines, -35 lines 0 comments Download
D content/browser/tab_contents/navigation_entry.h View 1 chunk +0 lines, -198 lines 0 comments Download
D content/browser/tab_contents/navigation_entry.cc View 1 chunk +0 lines, -211 lines 0 comments Download
A + content/browser/tab_contents/navigation_entry_impl.h View 7 chunks +37 lines, -37 lines 0 comments Download
A + content/browser/tab_contents/navigation_entry_impl.cc View 5 chunks +48 lines, -51 lines 0 comments Download
A + content/browser/tab_contents/navigation_entry_impl_unittest.cc View 7 chunks +25 lines, -26 lines 0 comments Download
D content/browser/tab_contents/navigation_entry_unittest.cc View 1 chunk +0 lines, -179 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.h View 5 chunks +10 lines, -8 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 10 chunks +14 lines, -14 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 12 chunks +36 lines, -35 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 20 chunks +26 lines, -24 lines 0 comments Download
M content/browser/tab_contents/tab_contents_unittest.cc View 25 chunks +29 lines, -28 lines 0 comments Download
M content/browser/tab_contents/test_tab_contents.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 12 months ago (2011-12-28 20:17:26 UTC) #1
Jói
LGTM Note (for posterity) that the change description says "Rename NavigationController to NavigationControllerImpl" but actually ...
8 years, 12 months ago (2011-12-29 13:28:49 UTC) #2
jam
8 years, 12 months ago (2011-12-29 18:01:21 UTC) #3 
On 2011/12/29 13:28:49, Jói wrote:
> LGTM
> 
> Note (for posterity) that the change description says "Rename
> NavigationController to NavigationControllerImpl" but actually this should
have
> been "Rename NavigationEntry to NavigationEntryImpl".
> 
> Cheers,
> Jói

oops, I got mixed up while working on both of them in parallel!

Powered by Google App Engine
This is Rietveld 408576698