Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6486)

Unified Diff: chrome/browser/safe_browsing/browser_feature_extractor.cc

Issue 8956059: Rename NavigationController to NavigationControllerImpl and put it into the content namespace. Al... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/rlz/rlz_unittest.cc ('k') | chrome/browser/safe_browsing/client_side_detection_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/browser_feature_extractor.cc
===================================================================
--- chrome/browser/safe_browsing/browser_feature_extractor.cc (revision 115900)
+++ chrome/browser/safe_browsing/browser_feature_extractor.cc (working copy)
@@ -28,6 +28,7 @@
#include "googleurl/src/gurl.h"
using content::BrowserThread;
+using content::NavigationEntry;
using content::WebContents;
namespace safe_browsing {
@@ -52,7 +53,7 @@
int index,
const std::vector<GURL>& redirect_chain,
ClientPhishingRequest* request) {
- content::NavigationEntry* entry = controller.GetEntryAtIndex(index);
+ NavigationEntry* entry = controller.GetEntryAtIndex(index);
bool is_secure_referrer = entry->GetReferrer().url.SchemeIsSecure();
if (!is_secure_referrer) {
AddFeature(StringPrintf("%s%s=%s",
@@ -162,7 +163,7 @@
// The url that we are extracting features for should already be commited.
DCHECK_NE(index, -1);
for (; index >= 0; index--) {
- content::NavigationEntry* entry = controller.GetEntryAtIndex(index);
+ NavigationEntry* entry = controller.GetEntryAtIndex(index);
if (url_index == -1 && entry->GetURL() == request_url) {
// It's possible that we've been on the on the possibly phishy url before
// in this tab, so make sure that we use the latest navigation for
« no previous file with comments | « chrome/browser/rlz/rlz_unittest.cc ('k') | chrome/browser/safe_browsing/client_side_detection_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698