Issue 8954014: Protector: separate handling for several cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8954014: Protector: separate handling for several cases. (Closed)

Created:
9 years ago by Ivan Korotkov

Modified:
9 years ago

Reviewers:
whywhat

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Protector: separate handling for several cases. *) When old and new IDs are equal, ignores old ID (fallback to the prepopulated provider). *) When new and fallback providers have the same name, doesn't suggest to 'Change to <new provider>'. *) Ignores logo_id when comparing providers. BUG=107516 TEST=Manual: see bug description Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114659

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	chrome/browser/protector/default_search_provider_change.cc	View		3 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/8954014/1

9 years ago (2011-12-15 16:25:02 UTC) #3

Change committed as 114659

Expand Messages | Collapse Messages