Protector: separate handling for several cases.

chrome/browser/protector/default_search_provider_change.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/protector/base_setting_change.h"
@@ skipping 50 matching lines @@
         AreKeywordsSame(url, other_) &&
         TemplateURLRef::SameUrlRefs(url->url(), other_->url()) &&
         TemplateURLRef::SameUrlRefs(url->suggestions_url(),
                                     other_->suggestions_url()) &&
         TemplateURLRef::SameUrlRefs(url->instant_url(),
                                     other_->instant_url()) &&
         url->GetFaviconURL() == other_->GetFaviconURL() &&
         url->safe_for_autoreplace() == other_->safe_for_autoreplace() &&
         url->show_in_default_list() == other_->show_in_default_list() &&
         url->input_encodings() == other_->input_encodings() &&
-        url->logo_id() == other_->logo_id() &&
         url->prepopulate_id() == other_->prepopulate_id();
   }
 
  private:
   // Returns true if both |url1| and |url2| have autogenerated keywords
   // or if their keywords are identical.
   bool AreKeywordsSame(const TemplateURL* url1, const TemplateURL* url2) {
     return (url1->autogenerate_keyword() && url2->autogenerate_keyword()) ||
         url1->keyword() == url2->keyword();
   }
@@ skipping 68 matching lines @@
       new_histogram_id_(GetSearchProviderHistogramID(new_url)),
       default_search_provider_(NULL) {
   if (new_url) {
     new_id_ = new_url->id();
     new_name_ = new_url->short_name();
   }
   if (old_url) {
     old_id_ = old_url->id();
     old_name_ = old_url->short_name();
   }
+  if (old_id_ == new_id_) {
+    // This means someone has tampered with the search providers list but not
+    // with the ID. Old ID is useless in this case so the prepopulated default
+    // search provider will be used.
+    old_id_ = 0;
+    // TODO(ivankr): restore the default search provider from the backup table.
+  }
 }
 
 DefaultSearchProviderChange::~DefaultSearchProviderChange() {
 }
 
 bool DefaultSearchProviderChange::Init(Protector* protector) {
   BaseSettingChange::Init(protector);
 
   UMA_HISTOGRAM_ENUMERATION(
       kProtectorHistogramNewSearchProvider,
@@ skipping 95 matching lines @@
         IDS_SEARCH_ENGINE_CHANGE_NO_BACKUP_MESSAGE, fallback_name_);
 }
 
 string16 DefaultSearchProviderChange::GetApplyButtonText() const {
   if (new_id_) {
     if (new_id_ == fallback_id_) {
       // Old search engine is lost, the fallback search engine is the same as
       // the new one so no need to show this button.
       return string16();
     }
+    if (!new_name_.empty() &&
+        new_name_ == fallback_name_) {
+      // The fallback and new search engines have the same name but different
+      // IDs, which most likely is some fraud attempt, so don't suggest to
+      // apply the new setting.
+      return string16();
+    }
     if (new_name_.length() > kMaxDisplayedNameLength)
       return l10n_util::GetStringUTF16(IDS_CHANGE_SEARCH_ENGINE_NO_NAME);
     else
       return l10n_util::GetStringFUTF16(IDS_CHANGE_SEARCH_ENGINE, new_name_);
   } else if (old_id_) {
     // New setting is lost, offer to go to settings.
     return l10n_util::GetStringUTF16(IDS_SELECT_SEARCH_ENGINE);
   } else {
     // Both settings are lost: don't show this button.
     return string16();
@@ skipping 80 matching lines @@
            chrome::kSearchEnginesSubPage));
 }
 
 BaseSettingChange* CreateDefaultSearchProviderChange(
     const TemplateURL* actual,
     const TemplateURL* backup) {
   return new DefaultSearchProviderChange(backup, actual);
 }
 
 }  // namespace protector