Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 8952014: Reland of r114615: "chrome.clear: Increasing granularity of public API" (Closed)

Created:
9 years ago by Mike West
Modified:
9 years ago
Reviewers:
Finnur
CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Reland of r114615: "chrome.clear: Increasing granularity of public API" http://codereview.chromium.org/7717023 added more granular options to BrowsingDataRemover. This CL exposes those options to the chrome.clear extension API. Among other things, this means that chrome.clear.cookies() will _only_ clear cookies, not cookies and site data. At the moment, clearing any quota managed data type will clear them all. That is being addressed in http://codereview.chromium.org/7839029/ but is independent from changing the public interface. BUG=94334 TEST=browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2155 lines, -364 lines) Patch
M chrome/browser/browsing_data_remover.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_clear_api.h View 5 chunks +93 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_clear_api.cc View 7 chunks +78 lines, -38 lines 0 comments Download
D chrome/browser/extensions/extension_clear_api_constants.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/extensions/extension_clear_api_constants.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/extensions/extension_clear_apitest.cc View 1 chunk +0 lines, -23 lines 0 comments Download
A chrome/browser/extensions/extension_clear_test.cc View 1 chunk +100 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.json View 11 chunks +158 lines, -21 lines 0 comments Download
M chrome/common/extensions/docs/experimental.clear.html View 32 chunks +1710 lines, -90 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 chunk +6 lines, -0 lines 0 comments Download
D chrome/test/data/extensions/api_test/clear/api/background.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/api_test/clear/api/background.js View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/test/data/extensions/api_test/clear/api/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/api_test/clear/one_at_a_time/background.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/api_test/clear/one_at_a_time/background.js View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/test/data/extensions/api_test/clear/one_at_a_time/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Finnur
Rubberstamp, LGTM. Looks like the compile error should be fixed.
9 years ago (2011-12-15 11:09:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/8952014/1
9 years ago (2011-12-15 12:21:01 UTC) #2
commit-bot: I haz the power
9 years ago (2011-12-15 14:05:07 UTC) #3
Change committed as 114630

Powered by Google App Engine
This is Rietveld 408576698