chrome/browser/extensions/extension_function_test_utils.cc - Issue 8952014: Reland of r114615: "chrome.clear: Increasing granularity of public API"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function_test_utils.cc

Issue 8952014: Reland of r114615: "chrome.clear: Increasing granularity of public API" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_function_test_utils.cc

diff --git a/chrome/browser/extensions/extension_function_test_utils.cc b/chrome/browser/extensions/extension_function_test_utils.cc

index 99538077849d50df18d55913a63527c233696be1..442013d391f8019626b6cf473c09dd7a86fde7c0 100644

--- a/chrome/browser/extensions/extension_function_test_utils.cc

+++ b/chrome/browser/extensions/extension_function_test_utils.cc

@@ -138,8 +138,8 @@ base::Value* RunFunctionAndReturnResult(UIThreadExtensionFunction* function,

RunFunction(function, args, browser, flags);

EXPECT_TRUE(function->GetError().empty()) << "Unexpected error: "

<< function->GetError();

- EXPECT_TRUE(function->GetResultValue()) << "No result value found";

- return function->GetResultValue()->DeepCopy();

+ return (function->GetResultValue() == NULL) ? NULL :

+ function->GetResultValue()->DeepCopy();

}

// This helps us be able to wait until an AsyncExtensionFunction calls