Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: media/audio/win/audio_low_latency_output_win_unittest.cc

Issue 8949015: Allow the AudioLowLatencyInputOutput tests to run on bots where audio hardware is available. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Add the win input/output tests as well Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/win/audio_low_latency_input_win_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/win/audio_low_latency_output_win_unittest.cc
===================================================================
--- media/audio/win/audio_low_latency_output_win_unittest.cc (revision 114624)
+++ media/audio/win/audio_low_latency_output_win_unittest.cc (working copy)
@@ -143,15 +143,11 @@
// Convenience method which ensures that we are not running on the build
// bots and that at least one valid output device can be found.
static bool CanRunAudioTests(AudioManager* audio_man) {
- if (NULL == audio_man)
- return false;
-
- scoped_ptr<base::Environment> env(base::Environment::Create());
- if (env->HasVar("CHROME_HEADLESS"))
- return false;
// TODO(henrika): note that we use Wave today to query the number of
// existing output devices.
- return audio_man->HasAudioOutputDevices();
+ bool output = audio_man->HasAudioOutputDevices();
+ LOG_IF(WARNING, !output) << "No output devices detected.";
+ return output;
}
// Convenience method which creates a default AudioOutputStream object but
« no previous file with comments | « media/audio/win/audio_low_latency_input_win_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698