Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 8949014: Reverting due to compile failure on multiple bots. (Closed)

Created:
9 years ago by Finnur
Modified:
9 years ago
Reviewers:
Mike West
CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Reverting due to compile failure on multiple bots. Revert 114615 - chrome.clear: Increasing granularity of public API http://codereview.chromium.org/7717023 added more granular options to BrowsingDataRemover. This CL exposes those options to the chrome.clear extension API. Among other things, this means that chrome.clear.cookies() will _only_ clear cookies, not cookies and site data. At the moment, clearing any quota managed data type will clear them all. That is being addressed in http://codereview.chromium.org/7839029/ but is independent from changing the public interface. BUG=94334 TEST=browser_tests Review URL: http://codereview.chromium.org/8008012 TBR=mkwst@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2059 lines) Patch
M chrome/browser/browsing_data_remover.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_clear_api.h View 5 chunks +1 line, -93 lines 0 comments Download
M chrome/browser/extensions/extension_clear_api.cc View 7 chunks +38 lines, -78 lines 0 comments Download
A + chrome/browser/extensions/extension_clear_api_constants.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/extension_clear_api_constants.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/extension_clear_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/extensions/extension_clear_test.cc View 1 chunk +0 lines, -100 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_function_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.json View 11 chunks +21 lines, -158 lines 0 comments Download
M chrome/common/extensions/docs/experimental.clear.html View 14 chunks +3 lines, -1623 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 chunk +0 lines, -6 lines 0 comments Download
A + chrome/test/data/extensions/api_test/clear/api/background.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/api_test/clear/api/background.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/api_test/clear/api/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/api_test/clear/one_at_a_time/background.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/api_test/clear/one_at_a_time/background.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/api_test/clear/one_at_a_time/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Finnur
9 years ago (2011-12-15 10:15:32 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698