chrome/browser/extensions/extension_function_test_utils.cc - Issue 8949014: Reverting due to compile failure on multiple bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function_test_utils.cc

Issue 8949014: Reverting due to compile failure on multiple bots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_function_test_utils.cc

===================================================================

--- chrome/browser/extensions/extension_function_test_utils.cc (revision 114618)

+++ chrome/browser/extensions/extension_function_test_utils.cc (working copy)

@@ -138,8 +138,8 @@

RunFunction(function, args, browser, flags);

EXPECT_TRUE(function->GetError().empty()) << "Unexpected error: "

<< function->GetError();

- return (function->GetResultValue() == NULL) ? NULL :

- function->GetResultValue()->DeepCopy();

+ EXPECT_TRUE(function->GetResultValue()) << "No result value found";

+ return function->GetResultValue()->DeepCopy();

}

// This helps us be able to wait until an AsyncExtensionFunction calls

« no previous file with comments | « chrome/browser/extensions/extension_function_dispatcher.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »