Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 8940001: Reverting half the checkins that are suspected of breaking the world. (Closed)

Created:
9 years ago by Finnur
Modified:
9 years ago
Reviewers:
jeremy
CC:
chromium-reviews, arv (Not doing code reviews), yusukes+watch_chromium.org
Visibility:
Public.

Description

Reverting half the checkins that are suspected of breaking the world. Revert 114382 - Don't display spelling options in "Language Settings" pref panel on OS X We're removing Hunspell integration in favor of only using the native OS spell checker on OS X, see crbug.com/69944 for more details. This CL modifieds the "Languages and Settings..." preference pane to remove options related to spelling on the Mac. Specific changes: * In .grd file: don't include spelling-related strings on Mac. * Fixed description for IDS_OPTIONS_SETTINGS_USE_THIS_FOR_SPELL_CHECKING in .grd file to not mention ChromeOS. * In "Under the Hood" changed button title that opens Languages pref panel to just "Language Settings..." on Mac rather than "Languages and spell-checker Settings..." * In the Language settings panel - remove the right pane and bottom checkbox on the Mac (these relate to dictionary download and spell checking). * Change the background color of the language list pane to white on Mac. You can see before/after screenshots of this change here: crbug.com/69944#c16 . BUG=69944 TEST="Preferences->Under the hood" should have a "Languages and Spell-checker Settings..." button on non-Mac platforms and the subsequent pref pane should not be modified by this CL. On Mac, the button should be titled "Language Settings..." and the panel that opens should lack the right pane and only contain options to pick and re-order languages - it should not contain options related to spell checking. Review URL: http://codereview.chromium.org/8917002 TBR=jeremy@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114399

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -52 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +20 lines, -29 lines 0 comments Download
M chrome/browser/resources/options/language_options.css View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/resources/options/language_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/language_options.js View 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler_common.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Finnur
9 years ago (2011-12-14 10:08:06 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698