Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 8917002: Don't display spelling options in "Language Settings" pref panel on OS X (Closed)

Created:
9 years ago by jeremy
Modified:
9 years ago
CC:
chromium-reviews, arv (Not doing code reviews), yusukes+watch_chromium.org
Visibility:
Public.

Description

Don't display spelling options in "Language Settings" pref panel on OS X We're removing Hunspell integration in favor of only using the native OS spell checker on OS X, see crbug.com/69944 for more details. This CL modifieds the "Languages and Settings..." preference pane to remove options related to spelling on the Mac. Specific changes: * In .grd file: don't include spelling-related strings on Mac. * Fixed description for IDS_OPTIONS_SETTINGS_USE_THIS_FOR_SPELL_CHECKING in .grd file to not mention ChromeOS. * In "Under the Hood" changed button title that opens Languages pref panel to just "Language Settings..." on Mac rather than "Languages and spell-checker Settings..." * In the Language settings panel - remove the right pane and bottom checkbox on the Mac (these relate to dictionary download and spell checking). * Change the background color of the language list pane to white on Mac. You can see before/after screenshots of this change here: crbug.com/69944#c16 . BUG=69944 TEST="Preferences->Under the hood" should have a "Languages and Spell-checker Settings..." button on non-Mac platforms and the subsequent pref pane should not be modified by this CL. On Mac, the button should be titled "Language Settings..." and the panel that opens should lack the right pane and only contain options to pick and re-order languages - it should not contain options related to spell checking. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -26 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +29 lines, -20 lines 0 comments Download
M chrome/browser/resources/options/language_options.css View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/language_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/language_options.js View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/language_options_handler_common.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jeremy
Miarandac: Mac sanity + does the modified Mac UI look right to you? (see link ...
9 years ago (2011-12-12 08:30:37 UTC) #1
Yusuke Sato
LGTM. Sorry for the delay. On 2011/12/12 08:30:37, jeremy wrote: > Miarandac: Mac sanity + ...
9 years ago (2011-12-13 13:42:00 UTC) #2
Miranda Callahan
On 2011/12/13 13:42:00, Yusuke Sato wrote: > LGTM. Sorry for the delay. > > On ...
9 years ago (2011-12-13 13:49:29 UTC) #3
satorux1
LGTM
9 years ago (2011-12-13 14:13:31 UTC) #4
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-12-14 05:53:47 UTC) #5
jeremy
arv: Need an owner LGTM for the files in chrome/browser/resources, thanks!
9 years ago (2011-12-14 05:58:38 UTC) #6
James Hawkins
LGTM
9 years ago (2011-12-14 06:02:57 UTC) #7
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-12-14 06:04:03 UTC) #8
M-A Ruel
9 years ago (2011-12-14 15:00:53 UTC) #9
On 2011/12/14 06:04:03, I haz the power (commit-bot) wrote:
> No LGTM from valid reviewers yet.

Sorry for the annoyance, bug is now fixed.

Powered by Google App Engine
This is Rietveld 408576698