Issue 8937020: Revert 114320 (broke chrome_frame_tests) - Enable ChromeFrame net tests for IE versions 8 and bel...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8937020: Revert 114320 (broke chrome_frame_tests) - Enable ChromeFrame net tests for IE versions 8 and bel... (Closed)

Created:
9 years ago by willchan no longer on Chromium

Modified:
9 years ago

Reviewers:
ananta

CC:
chromium-reviews, robertshield, cbentzel+watch_chromium.org, darin-cc_chromium.org, amit, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 114320 (broke chrome_frame_tests) - Enable ChromeFrame net tests for IE versions 8 and below. Changes include the following:- 1. Get rid of the dummy AtlModule registration in the net test suite. This is no longer needed as there is a module instance instantiated by the content code. 2. The test suite class now instantiates the ShadowAtExitManager class which allows nesting of AtExitManager instances. This is needed because the ChromeFrame net tests suite now calls into ContentMain which also instantiates an AtExitManager instance. Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435 BUG=105435 TEST=ChromeFrame net tests should now run on the builders. Review URL: http://codereview.chromium.org/8898026 TBR=ananta@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114341

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
	M	base/test/test_suite.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome_frame/test/net/fake_external_tab.cc	View		3 chunks	+19 lines, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages