Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 8898026: Enable ChromeFrame net tests for IE versions 8 and below. Changes include the following:- (Closed)

Created:
9 years ago by ananta
Modified:
9 years ago
CC:
chromium-reviews, robertshield, cbentzel+watch_chromium.org, darin-cc_chromium.org, amit, brettw-cc_chromium.org
Visibility:
Public.

Description

Enable ChromeFrame net tests for IE versions 8 and below. Changes include the following:- 1. Get rid of the dummy AtlModule registration in the net test suite. This is no longer needed as there is a module instance instantiated by the content code. 2. The test suite class now instantiates the ShadowAtExitManager class which allows nesting of AtExitManager instances. This is needed because the ChromeFrame net tests suite now calls into ContentMain which also instantiates an AtExitManager instance. Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435 BUG=105435 TEST=ChromeFrame net tests should now run on the builders. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114320

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M base/test/test_suite.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/net/fake_external_tab.cc View 1 2 chunks +2 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ananta
9 years ago (2011-12-13 19:53:45 UTC) #1
M-A Ruel
+ darin and brettw since it is crossing my knowledge area. They worked on it ...
9 years ago (2011-12-13 19:58:20 UTC) #2
ananta
http://codereview.chromium.org/8898026/diff/1/chrome_frame/test/net/fake_external_tab.cc File chrome_frame/test/net/fake_external_tab.cc (right): http://codereview.chromium.org/8898026/diff/1/chrome_frame/test/net/fake_external_tab.cc#newcode717 chrome_frame/test/net/fake_external_tab.cc:717: // Temporarily disabled, http://crbug.com/105435. On 2011/12/13 19:58:20, Marc-Antoine Ruel ...
9 years ago (2011-12-13 20:07:06 UTC) #3
brettw
9 years ago (2011-12-13 22:55:18 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698