Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8934011: Rename IntentsHost -> WebIntentsDispatcher and IntentsDispatcher -> WebIntentsHost. (Closed)

Created:
9 years ago by Greg Billock
Modified:
9 years ago
Reviewers:
jam, James Hawkins
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Rename IntentsHost -> WebIntentsDispatcher and IntentsDispatcher -> WebIntentsHost. R=jhawkins@chromium.org,jam@chromium.org BUG=104980 TEST=WebIntentPickerControllerBrowsertest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115385

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add period #

Patch Set 3 : Merge to head #

Patch Set 4 : Fix merge #

Patch Set 5 : Merge to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -536 lines) Patch
M chrome/browser/external_tab_container_win.h View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 1 2 3 4 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/intents/intent_injector.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/intents/intent_injector.cc View 1 2 3 4 3 chunks +12 lines, -11 lines 0 comments Download
D content/browser/intents/intents_host_impl.h View 1 chunk +0 lines, -59 lines 0 comments Download
D content/browser/intents/intents_host_impl.cc View 1 chunk +0 lines, -55 lines 0 comments Download
A + content/browser/intents/web_intents_dispatcher_impl.h View 1 3 chunks +13 lines, -13 lines 0 comments Download
A + content/browser/intents/web_intents_dispatcher_impl.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
D content/public/browser/intents_host.h View 1 2 3 4 1 chunk +0 lines, -47 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 2 3 4 2 chunks +6 lines, -4 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
A + content/public/browser/web_intents_dispatcher.h View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
D content/renderer/intents_dispatcher.h View 1 chunk +0 lines, -69 lines 0 comments Download
D content/renderer/intents_dispatcher.cc View 1 chunk +0 lines, -185 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
A + content/renderer/web_intents_host.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + content/renderer/web_intents_host.cc View 6 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Greg Billock
9 years ago (2011-12-13 20:20:23 UTC) #1
James Hawkins
lgtm http://codereview.chromium.org/8934011/diff/1/content/browser/intents/web_intents_dispatcher_impl.h File content/browser/intents/web_intents_dispatcher_impl.h (right): http://codereview.chromium.org/8934011/diff/1/content/browser/intents/web_intents_dispatcher_impl.h#newcode33 content/browser/intents/web_intents_dispatcher_impl.h:33: // WebIntentsDispatcher implementation Missing period at end of ...
9 years ago (2011-12-13 20:52:06 UTC) #2
Greg Billock
http://codereview.chromium.org/8934011/diff/1/content/browser/intents/web_intents_dispatcher_impl.h File content/browser/intents/web_intents_dispatcher_impl.h (right): http://codereview.chromium.org/8934011/diff/1/content/browser/intents/web_intents_dispatcher_impl.h#newcode33 content/browser/intents/web_intents_dispatcher_impl.h:33: // WebIntentsDispatcher implementation On 2011/12/13 20:52:07, James Hawkins wrote: ...
9 years ago (2011-12-13 21:10:32 UTC) #3
Greg Billock
John, can you take a look? Need lgtm for content/* On 2011/12/13 21:10:32, Greg Billock ...
9 years ago (2011-12-14 22:36:18 UTC) #4
jam
I'm OOO, Avi can you take a look please?
9 years ago (2011-12-14 23:03:20 UTC) #5
jam
rubberstamp lgtm
9 years ago (2011-12-15 23:43:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/8934011/4001
9 years ago (2011-12-16 16:00:59 UTC) #7
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/browser.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/browser.cc ...
9 years ago (2011-12-16 16:01:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/8934011/9002
9 years ago (2011-12-16 18:22:10 UTC) #9
commit-bot: I haz the power
Try job failure for 8934011-9002 (retry) on linux_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-12-16 18:47:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/8934011/17002
9 years ago (2011-12-17 00:13:00 UTC) #11
commit-bot: I haz the power
Try job failure for 8934011-17002 (retry) (retry) on linux_rel for step "check_deps". It's a second ...
9 years ago (2011-12-17 01:13:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/8934011/17002
9 years ago (2011-12-19 17:52:28 UTC) #13
commit-bot: I haz the power
Try job failure for 8934011-17002 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years ago (2011-12-19 19:00:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gbillock@chromium.org/8934011/26001
9 years ago (2011-12-21 18:07:16 UTC) #15
commit-bot: I haz the power
9 years ago (2011-12-21 20:26:05 UTC) #16 
Change committed as 115385

Powered by Google App Engine
This is Rietveld 408576698