chrome.webRequest.*.removeListener removes callbacks that were registered multiple times

chrome.webRequest.*.removeListener removes callbacks that were registered multiple times

Because
- chrome.webRequest.*.addListener can be called multiple times with the same callback function, and
- chrome.webRequest.*.removeListener does not consider the filters and extraInfoSpec for removing a listener,
calling removeListener should remove all listeners that are registered for one callback.

BUG=107368
TEST=no


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114446

[battre, 2011-12-13 18:46:17]

Hi Matt,

what do you think of this approach?

Should we do this or make the removeListener function more complex (by adding
additional parameters). I lean towards this approach.

Please review.

Thanks,
Dominic

[Matt Perry, 2011-12-13 20:29:59]

LGTM. I expect removeListener to be used very rarely, and even less frequently
for removeListener(cb) where cb is registered multiple times. So this is fine.

Can you also update the documentation to point out this behavior?

[battre, 2011-12-13 21:48:21]

On 2011/12/13 20:29:59, Matt Perry wrote:
> LGTM. I expect removeListener to be used very rarely, and even less frequently
> for removeListener(cb) where cb is registered multiple times. So this is fine.
> 
> Can you also update the documentation to point out this behavior?

Yes, I will. I wonder, though, which is the best format. Whether we should
generate removeListener and hasListener Stubs for all events in the bottom part
of the API documentation, or whether we should mention it only on the upper,
static part of the page.

[commit-bot: I haz the power, 2011-12-14 12:08:47]

No LGTM from valid reviewers yet.

[commit-bot: I haz the power, 2011-12-14 14:45:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/8934008/1

[commit-bot: I haz the power, 2011-12-14 17:17:25]

Change committed as 114446