Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7936)

Unified Diff: chrome/renderer/resources/extensions/schema_generated_bindings.js

Issue 8934008: chrome.webRequest.*.removeListener removes callbacks that were registered multiple times (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/webrequest/test_api.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/schema_generated_bindings.js
diff --git a/chrome/renderer/resources/extensions/schema_generated_bindings.js b/chrome/renderer/resources/extensions/schema_generated_bindings.js
index 0b617cf8800bf26ab48959c3f825ed02d26cfec8..3840d5c862a02aad255f82cddedbc99245cb01e4 100644
--- a/chrome/renderer/resources/extensions/schema_generated_bindings.js
+++ b/chrome/renderer/resources/extensions/schema_generated_bindings.js
@@ -269,18 +269,16 @@ var chrome = chrome || {};
// Unregisters a callback.
chrome.WebRequestEvent.prototype.removeListener = function(cb) {
- var idx = this.findListener_(cb);
- if (idx < 0) {
- return;
- }
-
- var e = this.subEvents_[idx];
- e.subEvent.removeListener(e.subEventCallback);
- if (e.subEvent.hasListeners()) {
- console.error(
- "Internal error: webRequest subEvent has orphaned listeners.");
+ var idx;
+ while ((idx = this.findListener_(cb)) >= 0) {
+ var e = this.subEvents_[idx];
+ e.subEvent.removeListener(e.subEventCallback);
+ if (e.subEvent.hasListeners()) {
+ console.error(
+ "Internal error: webRequest subEvent has orphaned listeners.");
+ }
+ this.subEvents_.splice(idx, 1);
}
- this.subEvents_.splice(idx, 1);
};
chrome.WebRequestEvent.prototype.findListener_ = function(cb) {
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/webrequest/test_api.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698