Issue 8933005: Linux/Gtk: Setting "can-focus" to FALSE for edit link in avatar menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8933005: Linux/Gtk: Setting "can-focus" to FALSE for edit link in avatar menu. (Closed)

Created:
9 years ago by SanjoyPal

Modified:
9 years ago

Reviewers:
sail, Elliot Glaysher

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

Linux/Gtk: Setting "can-focus" to FALSE for edit link in avatar menu. edit link steals focus from menu item which hides edit link button in focus-out-event handler, so, it misses the click event. BUG=107348 TEST=As described in the bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114241

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	chrome/browser/ui/gtk/avatar_menu_item_gtk.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncj674@motorola.com/8933005/1

9 years ago (2011-12-13 17:47:52 UTC) #3

Change committed as 114241

Expand Messages | Collapse Messages